On Wed, Oct 11, 2017 at 06:41:37PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Create a probe scrubber with id 0. This will be used by xfs_scrub to > probe the kernel's abilities to scrub (and repair) the metadata. This no longer returns anything to userspace it indicate capabilities. I can see that the previous patch checks for valid/invalid input flags, so we have unknown feature checking in place, just not obviously through the probe function implementation. Can you expand this comment a little to explain where the supported feature checks occur and so all that is required here is a stub that does nothing? Otherwise, consider it: Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html