On Sat, Oct 14, 2017 at 10:07:51PM -0700, Shaohua Li wrote: > From: Shaohua Li <shli@xxxxxx> > > Basically this is a copy of commit 001e4a8775f6(ext4: implement cgroup > writeback support). Tested with a fio test, verified writeback is > throttled against cgroup io.max write bandwidth, also verified moving > the fio test to another cgroup and the writeback is throttled against > new cgroup setting. > > I created a test for this as attached, please try! I'll send the test out for > inclusion later. Hmmm. The test you appended just checks that bytes get written. That's pretty much useless for verification of the features you describe above (throttling rate it correct, dynamic throttle application as memcg config changes). You explicitly state this is a memcg IO QoS feature and that you have a set of fio tests that verify that it works as expected. We need those "works as expected" fio tests formalised into automated fstests. Both upstream fs developers and downstream distro QE departments need to be able to verify that the bandwidth control and throttling works as advertised - it's essential that we have regression tests for this.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
