On Thu, Oct 12, 2017 at 02:49:49PM -0600, Liu Bo wrote:
> When IO error occurs, xfs_io -c "pwrite -W/w" doesn't report errors
> while xfs_io -c "pwrite" -c "fsync" does.
>
> This changes "pwrite -W/w" to report errors when it should.
>
> Signed-off-by: Liu Bo <bo.li.liu@xxxxxxxxxx>
> ---
> io/pwrite.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/io/pwrite.c b/io/pwrite.c
> index 1c5dfca..71bcccc 100644
> --- a/io/pwrite.c
> +++ b/io/pwrite.c
> @@ -379,11 +379,18 @@ pwrite_f(
> }
> if (c < 0)
> goto done;
> - if (Wflag)
> - fsync(file->fd);
> - if (wflag)
> - fdatasync(file->fd);
> + if (Wflag) {
> + if (fsync(file->fd) < 0) {
> + perror("fsync");
> + goto done;
> + }
> + }
> + if (wflag) {
> + if (fdatasync(file->fd) < 0) {
> + perror("fdatasync");
Ok.
> + goto done;
So this is a new behavior -- previously we'd print the timing info even
if the f{data,}sync call fails. I don't know that the timing matters if
we fail to guarantee the data is on stable storage, but does anyone else
have opinions?
--D
> + }
> + }
> if (qflag)
> goto done;
> gettimeofday(&t2, NULL);
> --
> 2.9.4
>
> @@ -390,0 +397,0 @@
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
