On Tue, Oct 10, 2017 at 5:46 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: > On Tue, Oct 10, 2017 at 07:49:17AM -0700, Dan Williams wrote: >> Move xfs_break_layouts() to its own compilation unit so that it can be >> used for both pnfs layouts and MAP_DIRECT mappings. > ..... >> diff --git a/fs/xfs/xfs_pnfs.h b/fs/xfs/xfs_pnfs.h >> index b587cb99b2b7..4135b2482697 100644 >> --- a/fs/xfs/xfs_pnfs.h >> +++ b/fs/xfs/xfs_pnfs.h >> @@ -1,19 +1,13 @@ >> #ifndef _XFS_PNFS_H >> #define _XFS_PNFS_H 1 >> >> +#include "xfs_layout.h" >> + > > I missed this the first time through - we try not to put includes > in header files, and instead make sure each C file has all the > includes they require. Can you move this to all the C files that > need layouts and remove the include of the xfs_pnfs.h include from > them? Sure, will do. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
