On Wed, Oct 04, 2017 at 10:32:47AM +1100, Dave Chinner wrote:
> On Tue, Oct 03, 2017 at 01:41:08PM -0700, Darrick J. Wong wrote:
> > +/*
> > + * Scrub probe -- userspace uses this to probe if we're willing to
> > + * scrub or repair a given mountpoint.
> > + */
> > +int
> > +xfs_scrub_probe(
> > + struct xfs_scrub_context *sc)
> > +{
> > + if (sc->sm->sm_ino || sc->sm->sm_agno)
> > + return -EINVAL;
> > + if (sc->sm->sm_gen & ~XFS_SCRUB_FLAGS_OUT)
>
> sm_flags?
sm_gen is correct because in xfs_scrub_probe we reflect back to
userspace any valid scrub outflags that were passed in via sm_gen.
Therefore we have to check sm_gen for unknown output flags so that we
can error out on any invalid inputs from userland.
xfs_scrub_metadata() unconditionally clears all the out flags from
sm_flags on its way in, prior to any of the scrub handlers being called.
(It's possible I'm misunderstanding your question.)
--D
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@xxxxxxxxxxxxx
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
