On 9/22/17 6:35 AM, Carlos Maiolino wrote: > My previous patch: d3a304b6292168b83b45d624784f973fdc1ca674 check for > XFS_LI_FAILED flag xfs_iflush done, so the failed item can be properly > resubmitted. > > In the loop scanning other inodes being completed, it should check the > current item for the XFS_LI_FAILED, and not the initial one. > > The state of the initial inode is checked after the loop ends > > Kudos to Eric for catching this. Coverity, actually, I'm just the messenger. Fixes-coverity-id: 1417838 -Eric > Signed-off-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx> > --- > fs/xfs/xfs_inode_item.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_inode_item.c b/fs/xfs/xfs_inode_item.c > index 6d0f74ec31e8..015e8ee793a3 100644 > --- a/fs/xfs/xfs_inode_item.c > +++ b/fs/xfs/xfs_inode_item.c > @@ -745,7 +745,7 @@ xfs_iflush_done( > */ > iip = INODE_ITEM(blip); > if ((iip->ili_logged && blip->li_lsn == iip->ili_flush_lsn) || > - lip->li_flags & XFS_LI_FAILED) > + blip->li_flags & XFS_LI_FAILED) > need_ail++; > > blip = next; > -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
