Re: [PATCH 12/19] xfs: refactor xfs_bmap_add_extent_delay_real

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 21, 2017 at 03:28:26PM +0200, Christoph Hellwig wrote:
> [fullquote of a fullquote removed, sigh..]
> 
> > > +		temp = PREV.br_blockcount - new->br_blockcount;
> > > +		da_new = XFS_FILBLKS_MIN(xfs_bmap_worst_indlen(bma->ip, temp),
> > > +			startblockval(PREV.br_startblock));
> > 
> > Needs another indent?
> 
> 
> What for?

I thought the second line of a continued statement was indented ether
twice more or up to the paren, e.g.:

	da_new = XFS_FILBLKS_MIN(xfs_bmap_worst_indlen(bma->ip, temp),
			startblockval(PREV.br_startblock));

or:

	da_new = XFS_FILBLKS_MIN(xfs_bmap_worst_indlen(bma->ip, temp),
				 startblockval(PREV.br_startblock));

but never a single tab:

	da_new = XFS_FILBLKS_MIN(xfs_bmap_worst_indlen(bma->ip, temp),
		startblockval(PREV.br_startblock));

The 'startblockval' line only has one more tab indent than the
'da_new =' line.

--D

> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux