On Thu, Sep 21, 2017 at 06:23:15AM -0700, Christoph Hellwig wrote: > On Wed, Sep 20, 2017 at 03:27:00PM -0700, Darrick J. Wong wrote: > > Hope all the structure copies throughout this series don't get us into > > trouble on sparc (I think they're fine), but otherwise... > > I didn't know sparc had any problems with struct copies. But I haven't > had a sparc machine since 2002, so.. It only has trouble when either of the structs doesn't satisfy the memory alignment requirements. I /think/ this is mostly an issue dealing with packed on-disk metadata arrays (like btree blocks). Every now and then I get bug reports from the sparc people about kernel oopses that happen on sparc and not x64, and they usually turn out to be memory access problems. (AFAICT it's not a problem copying from one stack struct to another as you do in these patches, but something I have to keep an eye on...) --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
