On Tue, Sep 19, 2017 at 07:34:06AM -0700, Christoph Hellwig wrote: > On Tue, Sep 19, 2017 at 10:13:52AM -0400, Brian Foster wrote: > > Can we pass a boolean or flag to xfs_iomap_write_unwritten() to have it > > update the incore i_size after unwritten extent conversion? Then move > > (or remove) the associated update from xfs_dio_write_end_io(). > > I don't think we even need a flag - all three callers of > xfs_iomap_write_unwritten want to update the file size. Sounds reasonable to me. I wasn't sure if there was anything special about the pnfs case. isize should probably already be stable in the writeback case, so perhaps this would be fine as long as we ensure the in-core size only increases (as we currently do for di_size). Brian -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
