On 9/18/17 12:22 PM, Darrick J. Wong wrote: >>> @@ -254,15 +312,17 @@ libxfs_ialloc( >>> ip->i_d.di_extsize = pip ? 0 : fsx->fsx_extsize; >>> ip->i_d.di_dmevmask = 0; >>> ip->i_d.di_dmstate = 0; >>> - ip->i_d.di_flags = pip ? 0 : fsx->fsx_xflags; >>> + ip->i_d.di_flags = pip ? 0 : xfs_flags2diflags(ip, fsx->fsx_xflags); >> is this a bugfix? > No. > > Prior to this patch, the only fsx_xflags bits that mkfs could set are > the ones that correspond exactly to di_flags bits, so it was fine to set > them directly. Subtle and annoying, but it worked. > > However, the xfs_mkfs.c changes enable us to set FS_XFLAG_COWEXTSIZE, > which doesn't correspond to a di_flags bit, so now we need translation > functions to return the correct di_flags/di_flags2 values for the given > fsx_xflags. Oh, ok. Before I guess it was only XFS_DIFLAG_RTINHERIT, XFS_DIFLAG_PROJINHERIT and XFS_DIFLAG_EXTSZINHERIT. Fair enough, maybe I should have seen that. Thanks. (I might note it in the changelog on the way in, though, since it's subtle and annoying) ;) -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
