On 9/18/17 12:16 PM, Eric Sandeen wrote:
>> @@ -812,6 +813,12 @@ _("%s fork in %s inode %" PRIu64 " claims used block %" PRIu64 "\n"),
>> forkname, ftype, ino, b);
>> goto done;
>>
>> + case XR_E_COW:
>> + do_warn(
>> +_("%s fork in %s inode %" PRIu64 " claims CoW block %" PRIu64 "\n"),
>> + forkname, ftype, ino, b);
>> + goto done;
>> +
> why do cow blocks get a special case and custom warning vs the above cases
> that just say "metadata?"
>
> Obviously it's just nitpicking over the do_warn message string, just
> double checking on the consistency front.
And this was also found via the rmap, but that fact isn't printed like
it is for every other type. For that reason I'd probably rather just add
XR_RE_COW above the /* fallthrough */ too, for consistency. Thoughts?
Thanks,
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
