On Fri, Sep 15, 2017 at 01:00:22PM -0400, Brian Foster wrote: > > - da_new = temp + temp2; > > + da_new = PREV.br_blockcount + RIGHT.br_blockcount; > > da_new should be the new total indirect reservation. The above sets it > to the total/remaining delalloc block count. E.g., it should probably be > something like this: > > da_new = startblockval(PREV.br_startblock) + > startblockval(RIGHT.br_startblock); > > Or alternatively you could set da_new right before diff is calculated > and reuse it in that calculation. Otherwise the patch looks good. Indeed. And we should probably use da_new for the calculation of diff as well, or rather clean up the mess with the double xfs_mod_fdblocks. xfs_bmap_add_extent_delay_real is such a beast.. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
