Re: [PATCH 1/5] Include fcntl.h for O_EXCL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hm, in looking over these, I see that Felix Janda
already sent patches to fix all this back in Jan 2016;
[PATCH 0/6] xfsdump: Compile with musl libc

That was around the time of a maintainer handoff, and
it looks like they go lost.  Since Felix did the original
work, and those patches are already reviewed, I
think I'll pick them up to solve your issues.  Thanks for the
reminder though; unfortunately I /just/ released a new xfsdump
version, but this is probably reason enough to do a fresh release
so you (and Felix) can stop carrying patches.

In Felix's patches as well as in yours, the changelogs could
be improved a bit to say /why/ the changes are being made,
i.e. to support musl, which is more pedantic.  I'll add that
info on commit.

Thanks,
-Eric

On 9/9/17 7:30 PM, Khem Raj wrote:
> Fix
> error: 'O_CREAT' undeclared (first use in this function)
> 
> Signed-off-by: Khem Raj <raj.khem@xxxxxxxxx>
> ---
>  invutil/invidx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/invutil/invidx.c b/invutil/invidx.c
> index 67efdf7..325a9a1 100644
> --- a/invutil/invidx.c
> +++ b/invutil/invidx.c
> @@ -27,6 +27,7 @@
>  #include <sys/stat.h>
>  #include <string.h>
>  #include <uuid/uuid.h>
> +#include <fcntl.h>
>  
>  #include "types.h"
>  #include "mlog.h"
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux