On Sun, Sep 10, 2017 at 01:26:42AM +0200, Gionatan Danti wrote: > Il 10-09-2017 01:12 Dave Chinner ha scritto: > > > >Probably not. And, worse, you open up the possibility of torn > >"single sector" writes if the underlying device isn't a native 4k > >sector device. > > Good catch, I was not thinking on how sectsize=4K could interact > with non-4K disks. > > However, if using only 4K disks below the thin volumes/ZVOLs, should > I manually set sectsize=4K? > Or, again, I should stick with the default and stop worring? If a block device is presented with 512 sectors on 4k-only sector drives, then that's a bug. If it's doing so with 512e drives, then that's still a bug because it should be presenting as a 512 byte logical, 4096 byte physical sector size device and in that case mkfs.xfs will choose 4k sectors by default. IOWs, if the underlying device is correctly presented to mkfs.xfs then it will choose the correct sector size by default. dm-thinp does the right thing with sector sizes, but I have no idea about ZoL. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
