On Wed, Sep 06, 2017 at 07:19:00PM -0700, Khem Raj wrote: > When uuid is enabled then we see linking failures with gold linker e.g. > > libxfs/.libs/libxfs.so: error: undefined reference to 'uuid_compare' > libxfs/.libs/libxfs.so: error: undefined reference to 'uuid_copy' > clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation) That's libxfs, not xfs_spaceman.... > > Signed-off-by: Khem Raj <raj.khem@xxxxxxxxx> > --- > spaceman/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/spaceman/Makefile b/spaceman/Makefile > index 95ec3c0..060e0af 100644 > --- a/spaceman/Makefile > +++ b/spaceman/Makefile > @@ -9,7 +9,7 @@ LTCOMMAND = xfs_spaceman > HFILES = init.h space.h > CFILES = init.c file.c prealloc.c trim.c > > -LLDLIBS = $(LIBXCMD) > +LLDLIBS = $(LIBXCMD) $(LIBUUID) And spaceman doesn't link against libxfs, nor does libxcmd or spaceman use uuids so I don't see why this fixes a problem with libxfs... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
