Re: [PATCH 00/12] xfs: more and better verifiers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 28, 2017 at 11:16:29AM -0700, Darrick J. Wong wrote:
> Hi all,
> 
> This patch series combines all the random little fixes and improvements
> to the verifiers that we've been talking about for the past month or so
> into a single patch series!
> 
> We start by refactoring the long format btree block header verifier into
> a single helper functionn and de-macroing dir block verifiers to make
> them less shouty.  Next, we change verifier functions to return the
> approximate instruction pointer of the faulting test so that we can
> report more precise fault information to dmesg/tracepoints.  Then, we
> move on to creating verifiers for all the inline format fork formats,
> and create a helper function for _iget that can dispatch inline
> verification.  The ability to supply custom verifier functions will be
> used by xfs_repair to deal with corrupt inodes.  The last patch enables
> us to (re)check the structure of incore metadata buffers to try to
> detect memory corruption.
> 

This looks mostly sane to me on a first pass. I noticed that xfs/348 now
fails, though it looks like the test just needs an update for the
symlink verifier..? Otherwise some random questions to follow..

Brian


> --D
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux