[PATCH] mkfs: Remove messages printed when blocksize < physical sectorsize

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Linux kernel commit 6c6b6f28b3335fd85ec833ee0005d9c9dca6c003 (loop: set
physical block size to PAGE_SIZE) now sets PAGE_SIZE as the default
physical sector size of loop devices. On ppc64, this causes loop devices
to have 64k as the physical sector size.

With these changes, mkfs.xfs now prints error messages when filesystem
blocksize (4k) is less than underlying device's physical
sectorsize (64k). These messages (printed on stderr) now cause several
xfstests to fail on ppc64 machine since xfstests' _filter_mkfs() isn't
able to filter out stderr.

Also, the messages themselves describe a possible sub-optimal setup. But
the setup is still usable.

Hence this commit removes the calls to fprintf() used to print the
messages.

Signed-off-by: Chandan Rajendra <chandan@xxxxxxxxxxxxxxxxxx>
---
 mkfs/xfs_mkfs.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index dfffae7..0bb3897 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -2011,12 +2011,6 @@ _("Minimum block size for CRC enabled filesystems is %d bytes.\n"),
 					      XFS_MIN_SECTORSIZE;
 
 		if ((blocksize < sectorsize) && (blocksize >= ft.lsectorsize)) {
-			fprintf(stderr,
-_("specified blocksize %d is less than device physical sector size %d\n"),
-				blocksize, ft.psectorsize);
-			fprintf(stderr,
-_("switching to logical sector size %d\n"),
-				ft.lsectorsize);
 			sectorsize = ft.lsectorsize ? ft.lsectorsize :
 						      XFS_MIN_SECTORSIZE;
 		}
-- 
2.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux