On Sat, Sep 2, 2017 at 3:20 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: > On Sat, Sep 02, 2017 at 02:54:51PM -0700, Khem Raj wrote: >> Rename local variable progname to avoid a clash with libc >> global symbols > > What libc is causing this problem? > > And why is it considered ok for that libc to pollute the global > variable namespace with it's own internal variables? > I am building with -staitc -pie options xfs_mdrestore.o: relocation R_ARM_REL32 against external or undefined symbol `progname' can not be used when making a PIE executable; recompile with -fPIC libcs have __progname, So I will have to check where is progname coming from probably an external header. I think renaming to avoid conflict is good thing regardless. > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
