On Sat, Sep 02, 2017 at 06:32:45PM +0200, Christoph Hellwig wrote: > On Wed, Aug 16, 2017 at 08:44:54AM -0700, Darrick J. Wong wrote: > > On Wed, Aug 16, 2017 at 10:51:57AM +0200, Christoph Hellwig wrote: > > > Our loop in xfs_finish_page_writeback, which iterates over all buffer > > > heads in a page and then calls end_buffer_async_write, which also > > > iterates over all buffers in the page to check if any I/O is in flight > > > is not only inefficient, but also potentially dangerous as > > > end_buffer_async_write can cause the page and all buffers to be freed. > > > > > > Replace it with a single loop that does the work of end_buffer_async_write > > > on a per-page basis. > > > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > > > Looks ok, > > Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > > > I'm assuming 4.14 for this one, unless you know of people banging into > > use-after-free problems and therefore need it pushed into 4.13? > > Looks like it didn't make it into for-next for 4.14 either. Fortunately, I received this email just as I was about to kick off the weekend soak tests, so it'll be the last thing that goes in for 4.14 (assuming QA tests pass and all that stuff). It's a 3 day weekend which means it's easier to commandeer everything for a mass test. :) Anyway, thanks for the reminder(s) everyone. --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
