On 8/24/17 12:51 PM, Darrick J. Wong wrote: > On Thu, Aug 24, 2017 at 02:47:52PM +0300, Nikolay Borisov wrote: >> Currently the semantics of the -n argument are a bit idiosyncratic. We want the >> argument to be the limit of extents that are going to be output by the tool. This >> is clearly broken now as evident from the following example on a fragmented file: > > Please update the documentation, since the xfs_io fiemap section refers > readers to xfs_bmap(8), which says: > > "If this [-n] option is given, xfs_bmap obtains the extent list of the > file in groups of num_extents extents." > > Which is no longer correct, because now -n limits the number of records > output, if I'm reading this patch correctly. TBH I think -n for bmap is > also wrong... Yep. That's fine as patch 7/6 I think - this patch doesn't make the documentation any more wrong than it already is, but it does need to be fixed in any case. > The other patches leading up to this one have been > Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> Thanks! They looked good to me too modulo the one problem I found. -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
