On Sun, Aug 13, 2017 at 04:42:14PM +0200, Christoph Hellwig wrote: > Split xfs_trans_roll into a low-level helper that just rolls the > actual transaction and a new higher level xfs_trans_roll_inode > that takes care of logging and rejoining the inode. This gets > rid of the NULL inode case, and allows to simplify the special > cases in the deferred operation code. .... > diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c > index 2011620008de..c43e78b5c035 100644 > --- a/fs/xfs/xfs_trans.c > +++ b/fs/xfs/xfs_trans.c > @@ -1034,26 +1034,19 @@ xfs_trans_cancel( > * chunk we've been working on and get a new transaction to continue. > */ > int > -xfs_trans_roll( > - struct xfs_trans **tpp, > - struct xfs_inode *dp) > +__xfs_trans_roll( > + struct xfs_trans **tpp) Do we really need the "__" prefix? Seems unnecessary to me because all the existing callers are modified... Other than that, every else looks good. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
