On Tue, Aug 08, 2017 at 06:07:00PM -0700, Darrick J. Wong wrote: > If we fail a mount on account of cow recovery errors, it's possible that > a previous quotacheck left some dquots in memory. The bailout clause of > xfs_mountfs forgets to purge these, and so we leak them. Fix that. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > --- > fs/xfs/xfs_mount.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/xfs/xfs_mount.c b/fs/xfs/xfs_mount.c > index d463ab3..8a12118 100644 > --- a/fs/xfs/xfs_mount.c > +++ b/fs/xfs/xfs_mount.c > @@ -1029,6 +1029,8 @@ xfs_mountfs( > out_agresv: > xfs_fs_unreserve_ag_blocks(mp); > out_quota: > + /* Clean out dquots that might be in memory after quotacheck. */ > + xfs_qm_unmount(mp); > xfs_qm_unmount_quotas(mp); Should these calls be reversed? It looks like qm_unmount() can free m_quotainfo before qm_unmount_quotas() has a chance to release quota inodes and whatnot. Brian > out_rtunmount: > xfs_rtunmount_inodes(mp); > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
