Re: [PATCH 1/5 v2] mkfs: replace variables with opts table: -b,d,s options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/27/17 11:39 AM, Luis R. Rodriguez wrote:
> On Fri, Jul 21, 2017 at 02:34:48PM +0200, Jan Tulak wrote:
>> @@ -1609,6 +1593,7 @@ main(
>>  			break;
>>  		case 'b':
>>  			p = optarg;
>> +			uint64_t tmp;
> Note:
> 
> An extra variable added, just so we can get the current value parsed
> so we can then convert it to also set similar collateral variables.

Also, please don't declare variables in the middle of code like this,
we generally stick to C89 rules.

Thanks,
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux