Re: xfsprogs commit 4944defad4ae2cbcf056207490d7c597bb92cd7c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[cc xfs list]

On Sun, Jul 23, 2017 at 10:21:56AM -0400, David Shaw wrote:
> On Jul 22, 2017, at 10:13 PM, Jory A. Pratt <anarchy@xxxxxxxxxx> wrote:
> > 
> > Is there any specific reason you all have drop'd away from the posix
> > standard? This change introduces build failure as it no longer follows
> > the posix standard for stdout.
> > 
> > metadump.c:2875:10: error: assignment of read-only variable 'stdout'
> >   stdout = stderr;
> >          ^
> > metadump.c:2911:10: error: assignment of read-only variable 'stdout'
> >   stdout = outf;

Huh?  What system configuration (libc, etc.) is this?

The Open Group Base Specifications Issue 7
http://pubs.opengroup.org/onlinepubs/9699919799/functions/stdin.html
only mentions this:

    extern FILE *stderr, *stdin, *stdout;

and says that it defers to the ISO C standard.

The ISO C11 standard (draft 1570, anyway)
https://port70.net/~nsz/c/c11/n1570.txt
has this to say:

            stderr
            stdin
            stdout
    which are expressions of type ''pointer to FILE'' that point to the
    FILE objects associated, respectively, with the standard error,
    input, and output streams.

I don't see anything in there about stdout being read only, though I
suppose there's nothing in that explicitly requiring they be assignable.

<grumble> musl, isn't it...?

--D

> 
> Hi,
> 
> I think you may have meant this to go to Darrick Wong
> (darrick.wong@xxxxxxxxxx), cc'd.  I reported the bug (well,
> indirectly), but Darrick was the person who fixed it.
> 
> David
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux