On Mon, Jul 24, 2017 at 02:34:27PM +0800, Hou Tao wrote: > Hi Carlos, > > On 2017/7/20 21:15, Carlos Maiolino wrote: > > + struct xfs_inode *ip = INODE_ITEM(lip)->ili_inode; > > + > > + ASSERT(xfs_isiflocked(ip)); > Is it better to use "ASSERT(xfs_isiflocked(INODE_ITEM(lip)->ili_inode)) instead" ? > Otherwise there will be a gcc warning about the unused variable "ip" when > both CONFIG_XFS_DEBUG and CONFIG_XFS_WARN are turned off. > Yup, you are right, I missed it during testing thanks to my Ignore stdout while building :) I'll fix it, thanks for catching it > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Carlos -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
