On Thu, Jul 13, 2017 at 01:33:01PM +0200, Christoph Hellwig wrote:
> The comment mentioned the wrong lock. Also add an ASSERT to assert
> this locking precondition.
Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> fs/xfs/libxfs/xfs_attr.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
> index ef8a1c75a467..de7b9bd30bec 100644
> --- a/fs/xfs/libxfs/xfs_attr.c
> +++ b/fs/xfs/libxfs/xfs_attr.c
> @@ -114,12 +114,14 @@ xfs_inode_hasattr(
> * Overall external interface routines.
> *========================================================================*/
>
> -/* Retrieve an extended attribute and its value. Must have iolock. */
> +/* Retrieve an extended attribute and its value. Must have ilock. */
> int
> xfs_attr_get_ilocked(
> struct xfs_inode *ip,
> struct xfs_da_args *args)
> {
> + ASSERT(xfs_isilocked(ip, XFS_ILOCK_SHARED | XFS_ILOCK_EXCL));
> +
> if (!xfs_inode_hasattr(ip))
> return -ENOATTR;
> else if (ip->i_d.di_aformat == XFS_DINODE_FMT_LOCAL)
> --
> 2.11.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
