On Thu, 2017-06-15 at 07:57 -0700, Christoph Hellwig wrote: > On Thu, Jun 15, 2017 at 06:42:12AM -0400, Jeff Layton wrote: > > Correct. > > > > But if there is a data writeback error, should we report an error on all > > open fds at that time (like we will for fsync)? > > We should in theory, but I don't see how to properly do it. In addition > sync_file_range just can't be used for data integrity to start with, so > I don't think it's worth it. At some point we should add a proper > fsync_range syscall, though. filemap_report_wb_err will always return 0 if the inode never has mapping_set_error called on it. So, I think we should be able to do it there once we get all of the fs' converted over. That'll have to happen at the end of the series however. -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
