Christoph Hellwig <hch@xxxxxx> wrote: > This reverts commit ff548773106ec7f8031bc6172e0234bd2a02c19c. > > The V1 uuid intrepreatation in struct form isn't really useful to the > rest of the kernel, and not really compatible to it either, so move it > back to AFS instead of polluting the global uuid.h. This isn't going to work. You've effectively changed the types of the fields in the UUID struct from BE to CPU-endian, but you're still calling generate_random_uuid(), which produces a BE UUID. You need to leave the struct members as __beXX or stop using the core UUID routines. Just move the struct uuid_v1 as-is to the afs headers and rename it to struct afs_uuid. You can then leave the (un)marshalling code alone. David -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html