On Tue, 2017-05-23 at 10:49 +0200, Christoph Hellwig wrote: > On Mon, May 22, 2017 at 09:49:17PM +0300, Andy Shevchenko wrote: > > > struct afs_call *call = container_of(work, struct > > > afs_call, > > > work); > > > - struct uuid_v1 *r = call->request; > > > + uuid_t *r = call->request; > > > > > > struct { > > > __be32 match; > > > > > > > Just to double check that this doesn't create a union aliasing. > > What do you mean with that? Since we introduced a union it's possible that we might access the member which wasn't last modified one. So, my comment is to give an attention on such possibility and avoid if there is an aliasing happened. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html