On Mon, May 22, 2017 at 12:13:22PM -0700, Christoph Hellwig wrote:
> Need to read up on the history and background a bit more, but some
> cosmetic comments below:
>
> > + lip = bp->b_fspriv;
> > + while (lip != NULL) {
> > + next = lip->li_bio_list;
> > +
> > + if (lip->li_ops->iop_error)
> > + lip->li_ops->iop_error(lip, bflags);
> > +
> > + lip = next;
> > + }
>
> for (lip = bp->b_fspriv; lip; lip = next) {
> next = lip->li_bio_list;
> if (lip->li_ops->iop_error)
> lip->li_ops->iop_error(lip, bflags);
> }
>
> ?
Agree, looks much better.
>
> > @@ -1101,6 +1119,7 @@ xfs_buf_iodone_callback_error(
> >
> > xfs_buf_ioerror(bp, 0);
> > xfs_buf_submit(bp);
> > +
> > return true;
> > }
>
> whitespace noise.
Fixed and queued for V3, thanks
--
Carlos
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
