On Wed, May 17, 2017 at 10:39:31AM +1000, Dave Chinner wrote: > On Tue, May 16, 2017 at 12:27:48PM -0700, Darrick J. Wong wrote: > > If a malicious user corrupts the refcount btree to cause a cycle between > > different levels of the tree, the next mount attempt will deadlock in > > the CoW recovery routine while grabbing buffer locks. We can use the > > ability to re-grab a buffer that was previous locked to a transaction to > > avoid deadlocks, so do that here. > > > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Missing comments in the code explaining the deadlock being avoided > by using xfs_trans_alloc_empty().... Heh, ok. --D > > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html