On Thu, May 11, 2017 at 02:40:09PM +0800, Shan Hai wrote: > The t_lsn is not used anymore and the t_commit_lsn is used as a tmp > storage for the checkpoint sequence number only in the current code. > > And the start/commit lsn are tracked as a transaction group tag in > the xfs_cil_ctx instead of a single transaction, so remove them from > the xfs_trans structure and their users to match with the design. > > Signed-off-by: Shan Hai <shan.hai@xxxxxxxxxx> > --- > fs/xfs/xfs_log_cil.c | 5 ++--- > fs/xfs/xfs_trace.h | 19 ------------------- > fs/xfs/xfs_trans.h | 4 ---- > 3 files changed, 2 insertions(+), 26 deletions(-) > > diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c > index 82f1cbc..373f5e8 100644 > --- a/fs/xfs/xfs_log_cil.c > +++ b/fs/xfs/xfs_log_cil.c > @@ -990,9 +990,8 @@ > if (tp->t_ticket->t_curr_res < 0) > xlog_print_tic_res(mp, tp->t_ticket); > > - tp->t_commit_lsn = cil->xc_ctx->sequence; > if (commit_lsn) > - *commit_lsn = tp->t_commit_lsn; > + *commit_lsn = cil->xc_ctx->sequence; > > xfs_log_done(mp, tp->t_ticket, NULL, regrant); > xfs_trans_unreserve_and_mod_sb(tp); > @@ -1008,7 +1007,7 @@ > * the log items. This affects (at least) processing of stale buffers, > * inodes and EFIs. > */ > - xfs_trans_free_items(tp, tp->t_commit_lsn, false); > + xfs_trans_free_items(tp, cil->xc_ctx->sequence, false); Can we add a local variable to store cil->xc_ctx->sequence to make this a little more clear? Otherwise this looks fine to me. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
