On 4/26/17 2:58 AM, Jan Tulak wrote: >> so is there any real advantage to converting all of these, only to remove >> most of them a few patches later? (If there is, just help me understand >> why...) >> > I wanted to avoid type changes in patches that replace variables in main > with opts use. Without this, I need to have the opts members in long > long, but I still get some changes int -> long long and even one or two > uint -> long long. So I wanted to have all the replaced variables already in a > single type, without the need to change format strings and knowing > that the type change is not causing any side effect. OK, fair enough. > But I think this shouldn't be a big issue (it doesn't seem that type > changes broke anything), so I'm rebasing the set without these uint > changes and the type transition can happen later on. Your argument above was reasonable, if you want to change them all for consistency before re-organization, that's ok too. Either way. -Eric > Cheers, > Jan > >> Thanks, >> -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
