Re: [PATCH] xfs_io: fix statx call for changed UAPI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 26, 2017 at 05:32:36PM -0500, Eric Sandeen wrote:
> Due to a late-breaking change in the statx UAPI in kernel commit
> 
> 1e2f82d1 statx: Kill fd-with-NULL-path support in favour of AT_EMPTY_PATH
> 
> we'll need to fix the way we call the syscall in xfs_io.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---

Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>

> 
> diff --git a/io/stat.c b/io/stat.c
> index c5b3075..783eb2e 100644
> --- a/io/stat.c
> +++ b/io/stat.c
> @@ -351,7 +351,7 @@ statx_f(
>  		return command_usage(&statx_cmd);
>  
>  	memset(&stx, 0xbf, sizeof(stx));
> -	if (_statx(file->fd, NULL, atflag, mask, &stx) < 0) {
> +	if (_statx(file->fd, "", atflag | AT_EMPTY_PATH, mask, &stx) < 0) {
>  		perror("statx");
>  		return 0;
>  	}
> diff --git a/io/statx.h b/io/statx.h
> index ff08e27..3b5978d 100644
> --- a/io/statx.h
> +++ b/io/statx.h
> @@ -4,6 +4,10 @@
>  #include <unistd.h>
>  #include <sys/syscall.h>
>  
> +#ifndef AT_EMPTY_PATH
> +#define AT_EMPTY_PATH	0x1000
> +#endif
> +
>  #ifndef AT_STATX_SYNC_TYPE
>  #define AT_STATX_SYNC_TYPE      0x6000  /* Type of synchronisation required from statx() */
>  #define AT_STATX_SYNC_AS_STAT   0x0000  /* - Do whatever stat() does */
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Carlos
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux