Re: [PATCH] xfs: strengthen log intent item refcount checking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 23, 2017 at 01:23:15AM -0700, Christoph Hellwig wrote:
> On Fri, Apr 21, 2017 at 01:00:43PM -0700, Darrick J. Wong wrote:
> > Use ASSERTs on the log intent item refcounts so that we fail noisily if
> > anyone tries to double-free the item.  This will help us diagnose
> > potential problems with the deferred-ops mechanism via generic/388.
> 
> Any specific problems you're looking at?

Not at the moment -- this was a debug patch I'd written up the last
there were refcounting problems with xfs_defer, and the refcount_t
discussions prompted me to send this in as a stopgap until we figure
out what we're doing w.r.t. refcount_t.

--D

> 
> Otherwise looks fine to me:
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux