On Wed, Apr 19, 2017 at 05:05:36PM -0500, Eric Sandeen wrote: > On 4/11/17 12:22 PM, Bill O'Donnell wrote: > > xfs_growfs manpage clearly states that the filesystem must > > be mounted to be grown. Current behavior allows xfs_growfs > > to proceed if the filesystem /containing/ the path > > of the desired target is mounted. This is not the specified > > behavior. Instead, also check the targeted fs argument against > > the entry found in the fstable lookup. Unless the targeted > > fs is actually mounted, reject the command. > > > > In order to cover bind-mounts, create a new lookup function > > based on the mountpoints instead of just the device name. > > > > Signed-off-by: Bill O'Donnell <billodo@xxxxxxxxxx> > > --- > > > > v2: in order to properly handle relative pathnames, symlinks, > > and bind-mounts, use realpath to establish canonical path name. > > This also requires the introduction of a lookup function based > > on the target mountpoint. > > I still need to review this one carefully, but have you made any > progress towards an xfstest for this behavior? xfstest is still a work in progress. Hopefully will have one by end of this week. Thanks- Bill > > Thanks, > -Eric > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
