On Mon, Apr 17, 2017 at 10:19:23AM -0400, Brian Foster wrote: > I don't see anything about setting minleft here that says the allocation > is required to come from one AG as opposed to that simply being > preferred. minleft must be in the same AG because we can't allocate from another AG in the same transaction. If we didn't respect this our whole allocator would break apart.. > Not all bmbt block allocations are tied to extent allocations. This is > the firstblock == NULLFSBLOCK case after all, which I take it means an > allocation hasn't yet occurred. IOW, what about other potentially > record-inserting operations like hole punch, extent conversion, etc.? Yes, for other ops we might not have allocated anything yet, but we might have to do more operations later and thus respect the minleft later. This is especially bad for directory operations that do multiple calls to xfs_bmapi_write in the same transaction. -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
