On Thu, Apr 13, 2017 at 12:01:32PM -0500, Eric Sandeen wrote: > On 4/13/17 10:50 AM, Darrick J. Wong wrote: > > On Thu, Apr 13, 2017 at 08:49:52AM -0500, Eric Sandeen wrote: > > >> --- > >> > >> xfs_metadump cannot obfuscate metadata in the filesystem log. Log > >> recovery of an obfuscated metadump image may expose clear-text > >> metadata and/or cause filesystem corruption in the restored image. > >> It is recommended that the source filesystem be mounted and unmounted > >> first if possible, to produce a metadump with a clean log. > > > > "It is recommended that the source filesystem first be mounted and > > unmounted, if possible, to ensure that the log is clean. That way, all > > metadata can be obfuscated correctly and the metadump will capture a > > clean log." > > > > ...because mounting and unmounting itself does not produce metadumps. :) > > That was the "first" bit, but "That way" is a bit colloquial IMHO. > <full_pedant_mode> > > How about: > > "It is recommended that the source filesystem first be mounted and > unmounted, if possible, to ensure that the log is clean. After that > operation, all metadata will be obfuscated correctly and xfs_metadump > will capture a clean log." "A subsequent invocation of xfs_metadump will capture a clean log and obfuscate all metadata correctly." More bikeshedding! Yay! :) --D > > -Eric > > > >> If a metadump must be produced from a filesystem with a dirty log, > >> it is recommended that obfuscation be turned off with -o option, if > >> metadata such as filenames is not considered sensitive. If obfuscation > >> is required on a metadump with a dirty log, please inform the recipient > >> of the metadump image about this situation. > > > > Otherwise seems fine to me. > > > > --D > > > >> --- > >> > >> -Eric > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > >> the body of a message to majordomo@xxxxxxxxxxxxxxx > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
