On 4/10/17 10:25 PM, Zorro Lang wrote: > On Mon, Apr 10, 2017 at 12:16:41PM -0500, Eric Sandeen wrote: >> On 4/6/17 7:05 AM, Zorro Lang wrote: >>> Due to xfs_repair uses direct IO, sometimes it can't read superblock >>> from an image file has smaller sector size than host filesystem. >>> Especially that superblock doesn't align with host filesystem's >>> sector size. >>> >>> Fortunately, xfsprogs already has code to do isa_file and geometry >>> check in xfs_repair.c, it turns off O_DIRECT after phase1() if the >>> sector size is less than the host filesystem's geometry. So move >>> the isa_file auto detection over up the phase1(), and try to do >>> once geometry check before phase1() if get_sb() return OK. >> >> Zorro, can you do a quick test for me - does a filesystem which fails >> repair without this patch also fail xfs_copy if the source and/or >> destination of the copy is on this same filesystem/device as the image >> file in your xfs_repair test? > > Sure, the xfs_copy has similar problem. I'm writting a xfstests case to > do xfs_repair and xfs_copy a file image likes this. Do you have any other > related suggestions which I can write them together? Any userspace which needs to read a filesystem image probably has the same issue. I'm wondering if all of this handling should somehow be factored out and re-used across the utilities... -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
