Re: [PATCH] libxfs: fix xfs_extent_busy_flush macro definition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/7/17 9:52 PM, Darrick J. Wong wrote:
> xfs_extent_busy_flush is a void function, so don't reduce it to zero.
> This shuts up gcc warnings about do-nothing statements.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

Whoops, thanks.  Need to test w/ newer gcc I guess, sorry!

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

> ---
>  libxfs/libxfs_priv.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libxfs/libxfs_priv.h b/libxfs/libxfs_priv.h
> index c2d4494..167786e 100644
> --- a/libxfs/libxfs_priv.h
> +++ b/libxfs/libxfs_priv.h
> @@ -419,7 +419,7 @@ roundup_64(__uint64_t x, __uint32_t y)
>  	*(busy_gen) = __foo;					\
>  	false;							\
>  })
> -#define xfs_extent_busy_flush(mp,pag,busy_gen)		(0)
> +#define xfs_extent_busy_flush(mp,pag,busy_gen)		do { } while(0)
>  
>  /* avoid unused variable warning */
>  #define xfs_alloc_busy_insert(tp,ag,b,len)	({	\
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux