Re: [RFC PATCH] iomap_dio_rw: Prevent reading file data beyond iomap_dio->i_size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 07, 2017 at 11:41:49AM +0530, Chandan Rajendra wrote:
> The above problem can also be recreated on a regular xfs filesystem
> using the command,
> 
> $ fsstress -d /mnt -l 1000 -n 1000 -p 1000

Can you add this to xfstests?

> +		if ((iov_iter_rw(iter) == READ) && (pos >= dio->i_size))
> +			break;

Please kill both sets of inner braces.

Otherwise this looks fine:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux