On Thu, Apr 6, 2017 at 4:41 PM, Jan Tulak <jtulak@xxxxxxxxxx> wrote: > Followup of my "[xfsprogs] Do we need so many data types for user input?" email. > > In the past, when mkfs was first written, it used atoi and > similar calls, so the variables were ints. However, the situation moved > since then and in course of the time, mkfs began to use other types too. > > Clean and unify it. We don't need negative values anywhere in the code and > some numbers has to be 64bit. Thus, uint64 is the best candidate as the target > type. > > This patch changes variables declared at the beginning of main() + block/sectorsize, making only minimal changes. The following patch cleans some now-unnecessary type casts. > > It would be nice to change types in some of the structures too, but > this might lead to changes outside of mkfs, so I'm skipping them for > this moment to keep it simple. > > Signed-off-by: Jan Tulak <jtulak@xxxxxxxxxx> > --- > mkfs/xfs_mkfs.c | 184 ++++++++++++++++++++++++++++---------------------------- > 1 file changed, 92 insertions(+), 92 deletions(-) > Public git tree for these changes: https://github.com/jtulak/xfsprogs-dev/tree/github-uint (It includes the other two small patches I submitted today too). Jan -- Jan Tulak jtulak@xxxxxxxxxx / jan@xxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
