On 3/28/17 2:07 PM, Amir Goldstein wrote: > On Tue, Mar 28, 2017 at 2:40 PM, Andreas Dilger <adilger@xxxxxxxxx> wrote: >> On Mar 28, 2017, at 8:38 AM, David Howells <dhowells@xxxxxxxxxx> wrote: >>> >>> Here are my current changes to Eric's statx interface patch. I've made it >>> analoguous to the stat command and so it only does statx-of-fd. >>> >>> I've made the "-m" flag able to take the words "basic" and "all" in >>> preference to a number and able to take an octal or hex number as an >>> alternative too. >>> >>> I've dropped the -A and -L flags since it no longer passes a path over. >>> >>> Finally, I've added a -c flag that causes an fstat() to be done as well and >>> the buffers compared as a consistency check. >> >> It probably makes sense to use "-C" to avoid confusion with xfs_io's "-c" >> option, and also the "stat -c" option to dump only specific fields (which >> may be useful to add at some point in the future as well). >> > > I'm afraid its not better for avoiding confusion. > -C already taken as well for new "oneshot commands"... There's no conflict here AFAICT; the "-C" for oneshot is for xfs_io invocation; individual commands are free to re-use such options for their own purposes. i.e.: # xfs_io -C "command -C" file is fine; the two different -C args have different contexts. Adding a -C to the statx command poses no problem. And with that public service announcement let me go read this thread and catch up... ;) -Eric > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
