On Fri, Mar 17, 2017 at 12:38 AM, Luis R. Rodriguez <mcgrof@xxxxxxxxxx> wrote: > On Wed, Mar 15, 2017 at 04:59:55PM +0100, Jan Tulak wrote: >> This set is a follow-up of some old discussions and further attempts to untangle >> the spaghetti in options parsing. In short, this patchset allows to define >> cross-option conflicts and makes the conflicts detection more robust. > > This series is pretty large. There are quite a bit of patches which just rename > something, or just shove code from one place to another. Can you group up > non-functional changes together first, and send a small series of simple stuff > with no functional changes first? > > That should reduce the size of the functional patch set, and make it clearer > which patches require much careful eyeballing. It should also put out of your > queue tons of changes which are trivial and can go in rather sooner. > I see... I will see how I can split it better. I guess not everything can be moved like this, but at least some changes can be moved. >> Config file patches addendum: >> >> (Thread: http://www.spinics.net/lists/linux-xfs/msg04703.html) >> >> I read through the changes, but decided to don't take anything from it. > > The last 2 patches of my config series are really the functional change there, > the rest is fluff to account for the insanity we have now. > >> I think it is time to do something and adding further changes would just >> push it down again. Nevertheless, the other patchset contains some changes >> (like splitting the main opts loop) that I wanted to add in some later patch >> too. > > OK. > >> I suggest that we first merge these patches I'm sending, and once it solves >> some of the issues Luis hit too, we can look again on the config file thing >> and even if the main idea fell out of favor for some reason, there are still >> other useful changes. > > Sure, I'm fine with this, do you have a git tree ? Once you rev and post new > series if you can provide a git URL that'd be great as then I can just work > off of that. > >> PS: I'm traveling at Vault next week, so if you are there too, we can open it >> there. > > I'm up for beers there. > Great. :-) Cheers, Jan -- Jan Tulak jtulak@xxxxxxxxxx / jan@xxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
