On Wed, Mar 08, 2017 at 06:16:57PM -0600, Eric Sandeen wrote: > On 3/3/17 5:13 PM, Luis R. Rodriguez wrote: > > This series adds mkfs.xfs.conf support, so that options can now be > > shoved into a configuration file. This enables certain defaults to be > > saved for folks sticking to certain values, but more importantly it > > also enables distributions to override certain defaults so that new > > filesystems remain compatible with older distributions. > > > > This has been based on top of xfsprogs-dev v4.9.0-rc1. > > > > Given we already have an existinsg infrastructure to validate argument > > values this reuses that infrastructure by first adding helpers and porting > > over the argument parsing suppor to use these helpers. > > Hm, one functional problem with this, aside from Dave's concerns and > suggestions, is that many options in the config file can't actually > be overridden on the commandline because they are treated as having > been respecified, which is not allowed: > > # mkfs.xfs -m crc=1 -m crc=0 -f fsfile > -m crc option respecified > Usage: mkfs.xfs This was dealt by enabling the last option taken to override, and this mechanism was also taken to enable the config file to take the first value but let the command line to override. Refer to usage of reset_opt(). Granted I had only done this on B_LOG but this can easily be made to enable us to reset for all options. If we don't want to enable subsequent command line entries to override (to keep old behaviour) but still allow at least the command line to override the config file options, that's also doable. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
