On Tue, Mar 07, 2017 at 05:22:55PM +0000, David Howells wrote: > Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > > This would be great to have in 4.11 together with the initial statx > > implementation. But until I see documentation and testcases for statx > > I don't really feel comfortable reviewing anything related to it. > > Well, since you asked for documentation, here's a manual page for you to > review:-) > > Note that as it isn't in glibc yet, I've left out all the > set-this-and-that-#define-to-make-it-appear stuff except where it is pertinent > to particular constants. > > I don't suppose you know where the documentation on writing xfstests tests is? > xfstests-dev/doc/ only contains an old and out of date changelog. There's a "ADDING TO THE FSQA SUITE" section in README file, basically it's telling you to use './new' script to generate new test template. So based on what type of new test you're going to create, you could run: ./new generic # new generic test ./new xfs # new xfs test ./new ext4 # new ext4 test ./new shared # new shared test ... It finds the first free seq number and creates test template and a default .out file in tests/<type> dir and add a new entry in tests/<type>/group file. You could just edit the template and update the .out file with expected output from the test run. E.g. currently 416 is the first free seq number in generic tests, ./new generic will create ./tests/generic/416 ./tests/generic/416.out I think statx test should be a new generic test. Thanks, Eryu -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
