On Wed, Mar 01, 2017 at 09:36:49AM -0500, Brian Foster wrote: > This is a stab at fixing the regression discussed in this[1] thread > based on what Christoph mentioned regarding use of the IOMAP_F_NEW flag. > I decided to co-opt the XFS_BMAPI_ENTIRE flag for the delalloc res bit > since it seems logically equivalent, but we could define a new flag too. > I considered as such to preserve default behavior of > _reserve_delalloc(), but otoh there is only one other caller. Otherwise, > this passes all of my testing so far. Thoughts? I don't like reusing the flag that much, but I think instead of passing the flag we could trivially just remove the xfs_bmbt_get_all in xfs_bmapi_reserve_delalloc and let the caller handle it after xfs_bmapi_reserve_delalloc returned. That being said I see no good reason why the COW would care to see the merged extent, so unconditionally removing it should be fine as well. Or did I miss something? -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
