This looks fine to me, but instead of the global res variable please use local variables in the if blocks (and maybe give them a better name like err). -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html