Re: [PATCH 1/2] xfs: simplify xfs_rtallocate_extent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 16, 2017 at 05:02:32PM -0800, Darrick J. Wong wrote:
> >  	ASSERT(xfs_isilocked(mp->m_rbmip, XFS_ILOCK_EXCL));
> >  	ASSERT(minlen > 0 && minlen <= maxlen);
> > -
> > +	
> 
> Inserted whitespace?

Yeah, fixed.

> > -	if (error)
> > -		return error;
> 
> We shouldn't be ignoring errors from xfs_rtallocate_extent_*, right?

No, we shouldn't.  I'll add the check back.
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux