On Fri, Feb 10, 2017 at 08:25:23AM -0800, Darrick J. Wong wrote: > On Fri, Feb 10, 2017 at 08:58:30AM -0500, Brian Foster wrote: > > On Fri, Feb 10, 2017 at 03:15:19PM +0800, Eryu Guan wrote: > > > On Thu, Feb 09, 2017 at 02:43:41PM -0500, Brian Foster wrote: > > > > Hi all, > > > > > > > > This series is associated with the "buffered write and indlen fixes" > > > > series recently posted to the XFS list. These patches move the original > > > > test to the XFS directory as it now depends on an XFS-specific > > > > mechanism, restore the effectiveness of the original test, and finally > > > > enhance the test to reproduce the newly identified problems fixed by the > > > > kernel patches. Thoughts, reviews, flames appreciated. > > > > > > I think it's still worth keeping the original fzero tests in generic, as > > > a generic function/regression test, though it's not effective to > > > reproduce the original bug. And maybe it's still working and effective > > > on some distro kernels? How about just adding a new test for XFS? > > > > > > > Sure, in that case I guess I can just copy generic/033 rather than move > > it and then squash these down into a single patch. Any other comments on > > the resulting test before I post an update? > > /me thinks the new test ought to _notrun if the fail_writes file doesn't > show up... that said /me is sorta braindead after a lot of travel > yesterday and could've missed it already being there. :( > Yep, there's a '_require_xfs_sysfs ...' in there that skips the test as appropriate. Brian > --D > > > > > Brian > > > > > Thanks, > > > Eryu > > > -- > > > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
